readme triggers - #3568
Conversation
|
Warning Review limit reached
More reviews will be available in 49 minutes and 25 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughFive README files had heading punctuation adjusted. GitHub Actions workflows now compute a sanitized branch-name output and all preview deployment and removal jobs use that sanitized value to construct Azure preview APP names. ChangesREADME Heading Punctuation
Azure preview workflow: sanitized branch-name
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
New azure website changes available for preview here |
|
New azure docs changes available for preview here |
|
New azure analytics_platform changes available for preview here |
|
New azure vertex changes available for preview here |
|
New azure beacon changes available for preview here |
|
New azure website changes available for preview here |
|
New azure docs changes available for preview here |
|
New azure analytics_platform changes available for preview here |
|
New azure vertex changes available for preview here |
|
New azure beacon changes available for preview here |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy-frontend-azurepreview.yml:
- Around line 25-38: The cleanup workflows still compute the app-name from the
raw lowercase branch substring (e.g., `${BRANCH:0:12}` / `lowercase`) causing
mismatched names when the 12-char prefix ends with '-' — update all
remove-*-preview jobs to use the same sanitized value used by deploy (the
`sanitize` step output, e.g., `${{ steps.sanitize.outputs.sanitized }}`) when
constructing the app name (replace `${BRANCH:0:12}-<service>-preview` or uses of
`lowercase` with the sanitized output) so deletion targets the exact names
created by the deploy workflow.
- Around line 33-38: The sanitize step currently injects untrusted
branch-derived text directly into a shell expression (using RAW="${{
steps.string.outputs.lowercase }}"), which risks shell-injection; change the
sanitize job to pass the lowercase value via env: (e.g., env: RAW: ${{
steps.string.outputs.lowercase }}) and use a safe, non-evaluating command such
as printf '%s' "$RAW" | cut -c1-12 | sed 's/-*$//' to produce CLEAN, then write
the output to GITHUB_OUTPUT using a quoted echo/printf (e.g., printf
"sanitized=%s\n" "$CLEAN" >> "$GITHUB_OUTPUT") to avoid
word-splitting/evaluation. Also ensure cleanup uses the same normalized output
symbol needs.branch-name.outputs.sanitized (not
needs.branch-name.outputs.lowercase) and applies the identical truncation/trim
logic so preview app names match between deploy and remove steps.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 77f7c4fb-942f-40ca-bef2-1efc59cc6eb0
📒 Files selected for processing (1)
.github/workflows/deploy-frontend-azurepreview.yml
|
New azure docs changes available for preview here |
|
New azure website changes available for preview here |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/deploy-frontend-azurepreview.yml:
- Line 29: Replace the unpinned action reference "uses:
ASzc/change-string-case-action@v5" with the commit-pinned reference using the v5
tag’s SHA so the workflow is pinned to a specific commit; update the uses line
to "ASzc/change-string-case-action@07c1e24a97f0951e13f88870b99c058fcf0b14cf"
(keep the same action name but swap the tag for the given SHA).
In @.github/workflows/remove-deploy-azurepreview.yml:
- Around line 22-33: The workflow uses ASzc/change-string-case-action@v2 while
the deploy workflow uses `@v5`, which can cause differing sanitized branch names;
update the "uses" entry for the string-case action in this file to the exact
same version (or pinned commit hash) as the deploy workflow (replace
ASzc/change-string-case-action@v2 with the same `@v5` or commit ref), then verify
the sanitize step that reads env RAW and computes CLEAN remains compatible so
both workflows produce identical sanitized values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 24eb219e-e277-487e-8ba4-3fdd66d724be
📒 Files selected for processing (2)
.github/workflows/deploy-frontend-azurepreview.yml.github/workflows/remove-deploy-azurepreview.yml
|
|
||
| steps: | ||
| - id: string | ||
| uses: ASzc/change-string-case-action@v5 |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Fetch the current commit SHA for ASzc/change-string-case-action v5
gh api repos/ASzc/change-string-case-action/git/ref/tags/v5 --jq '.object.sha' 2>/dev/null || echo "Could not resolve tag"Repository: airqo-platform/AirQo-frontend
Length of output: 114
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE=".github/workflows/deploy-frontend-azurepreview.yml"
echo "---- File head (first 120 lines) ----"
nl -ba "$FILE" | sed -n '1,120p'
echo "---- Lines around 29 ----"
nl -ba "$FILE" | sed -n '20,45p'
echo "---- Extract on: section (quick) ----"
awk 'BEGIN{in_on=0}
/^(on:|on )/{in_on=1}
in_on{print}
/^[^ ]/ && in_on && $0 !~ /^on:/ {exit}' "$FILE" || trueRepository: airqo-platform/AirQo-frontend
Length of output: 172
🏁 Script executed:
#!/bin/bash
set -euo pipefail
FILE=".github/workflows/deploy-frontend-azurepreview.yml"
echo "== sanity: file = $FILE =="
ls -la "$FILE" || true
echo "== first 140 lines =="
cat -n "$FILE" | sed -n '1,140p'
echo "== around uses line (lines 20-60) =="
cat -n "$FILE" | sed -n '20,60p'
echo "== grep for pull_request_target / pull_request =="
rg -n "pull_request_target|pull_request" "$FILE" || trueRepository: airqo-platform/AirQo-frontend
Length of output: 8930
Pin ASzc/change-string-case-action to a commit SHA for supply-chain security.
This workflow runs on pull_request_target and currently uses ASzc/change-string-case-action@v5 (line 29). Pin it to the v5 tag’s commit SHA: 07c1e24a97f0951e13f88870b99c058fcf0b14cf.
Example pin format
- id: string
- uses: ASzc/change-string-case-action@v5
+ uses: ASzc/change-string-case-action@07c1e24a97f0951e13f88870b99c058fcf0b14cf # v5
with:
string: ${{ github.head_ref || github.ref_name }}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| uses: ASzc/change-string-case-action@v5 | |
| - id: string | |
| uses: ASzc/change-string-case-action@07c1e24a97f0951e13f88870b99c058fcf0b14cf # v5 | |
| with: | |
| string: ${{ github.head_ref || github.ref_name }} |
🧰 Tools
🪛 zizmor (1.25.2)
[error] 29-29: unpinned action reference (unpinned-uses): action is not pinned to a hash (required by blanket policy)
(unpinned-uses)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/deploy-frontend-azurepreview.yml at line 29, Replace the
unpinned action reference "uses: ASzc/change-string-case-action@v5" with the
commit-pinned reference using the v5 tag’s SHA so the workflow is pinned to a
specific commit; update the uses line to
"ASzc/change-string-case-action@07c1e24a97f0951e13f88870b99c058fcf0b14cf" (keep
the same action name but swap the tag for the given SHA).
|
New azure analytics_platform changes available for preview here |
|
New azure vertex changes available for preview here |
|
New azure beacon changes available for preview here |
|
New azure website changes available for preview here |
|
New azure docs changes available for preview here |
|
New azure analytics_platform changes available for preview here |
|
New azure vertex changes available for preview here |
|
New azure beacon changes available for preview here |
Summary of Changes (What does this PR do?)
Status of maturity (all need to be checked before merging):
How should this be manually tested?
What are the relevant tickets?
Screenshots (optional)
Summary by CodeRabbit
Documentation
Chores