Conversation
…onents with the useBanner hook.
…ML error responses
…OG_CLOSE_MS constant
…etTimeout banner patter
…etTimeout banner patter
… via GENERIC_ERROR constant
…dule-to-use-InfoBanners feat(grids): Replace all toast-based feedback in grid management components
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ting fix: gate posthog analytics events
…rredBanner in assign/unassign dialogs
- Added app and screenshot_url fields to FeedbackSubmission interface. - Updated waitForNextAuthSession to validate expected access token. - Improved OAuth token handling in AuthProvider for better session management. - Refactored FeedbackDetailsContent to display additional feedback metadata and improve UI components.
…pending group switches
…and update Toast component accessibility roles
…Module-to-use-InfoBanners Update cohort management module to use info banners
Introduce a new authRequired field to the device import flow: add it to EXPECTED_FIELDS, include UI select input, and default it to true on new/cleared forms. Update parsing to detect common CSV header aliases for authentication, convert string values (true/1/yes/etc.) to boolean, and ensure transformed preview/types include boolean. Also tighten payload cleanup logic to remove empty strings/undefined/null/empty arrays, adjust handleInputChange to accept boolean, and update useImportDevice types to include authRequired.
Enhance feedback details and authentication handling
…er feedback Replace setErrors with showBanner for error notifications in the ImportDeviceModal component. This change enhances user experience by providing scoped error messages for various validation scenarios, including file type checks and required field mappings. Additionally, update the UI to display the new authRequired field in the device import table.
… error banner Add validation for the authRequired field in the ImportDeviceModal component. If invalid values are detected during the import process, an error banner is shown to the user, indicating the specific rows with issues. This improves user feedback and ensures correct data entry for authentication requirements.
Add auth required field to import device flow
Baalmart
marked this pull request as ready for review
May 28, 2026 13:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.