Add explicit http server/client compression support#1660
Open
wendigo wants to merge 1 commit into
Open
Conversation
wendigo
force-pushed
the
serafin/explicit-compression
branch
from
29687d2 to
d6d5941
Compare
3 tasks
oneonestar
reviewed
Feb 19, 2026
Comment on lines
+484
to
+486
| catch (Exception e) { | ||
| return Optional.empty(); | ||
| } |
There was a problem hiding this comment.
When does this happen and why are we ignoring it silently?
Comment on lines
+380
to
+383
| if (config.isDeflateCompressionEnabled()) { | ||
| createContentDecoderFactory(new GzipCompression()) | ||
| .ifPresent(httpClient.getContentDecoderFactories()::put); | ||
| } |
There was a problem hiding this comment.
Deflate and gzip are different.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Content-Encoding#deflate
Content-Encoding: gzip
Content-Encoding: deflate
deflate
Using the zlib structure (defined in RFC 1950) with the deflate compression algorithm (defined in RFC 1951).
gzip
A format using the Lempel-Ziv coding (LZ77), with a 32-bit CRC. This is the original format of the UNIX gzip program.
Contributor
|
@wendigo any progress on this .. we need it for Trino Gateway trinodb/trino-gateway#765 |
Contributor
|
Ping @wendigo .. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Airlift contribution check list