Skip to content

Deny static import for builder #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
electrum merged 2 commits into from
Mar 7, 2023
Merged

Deny static import for builder #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9546a66
Deny static import for builder
ssheikin Mar 4, 2023
be61d28
Update CHANGES.md
electrum Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ Airbase 134

* Enforcer updates:
- Enable `requirePluginVersions` check
* Checkstyle updates:
- Deny static import for `builder`
* Plugin updates:
- Enforcer 3.2.1 (from 3.1.0)

Expand Down
4 changes: 2 additions & 2 deletions airbase-policy/src/main/resources/checkstyle/airbase-checks.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
</module>

<module name="RegexpSingleline">
<property name="format" value="^import static .*\.(of|copyOf|valueOf);$" />
<property name="message" value="The following methods may not be statically imported: of, copyOf, valueOf" />
<property name="format" value="^import static .*\.(of|copyOf|valueOf|builder);$" />
<property name="message" value="The following methods may not be statically imported: of, copyOf, valueOf, builder" />
</module>
<module name="RegexpSingleline">
<property name="format" value="^import static (?!java\.lang\.String\.format;).*\.format;" />
Expand Down