Skip to content
This repository has been archived by the owner on Sep 1, 2022. It is now read-only.

Technical test - Bingbing YAN #37

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

bingbing-yan
Copy link

@bingbing-yan bingbing-yan commented Jul 20, 2020

Features

  • Fetch calls and display a list of calls by date on feed page
  • Display call's info and an "Archive" button on detail page
  • Archive a call by clicking on "Archive" button

If you want to review the PR from github, I recommend to you review by commit.
If you want to run it on your machine, you need yo set node version >= 10.14.2, and run

yarn install
yarn start

Screenshot

Feed page Detail page
Capture d’écran 2020-07-20 à 18 13 06 Capture d’écran 2020-07-20 à 18 13 45

To improve

  • Increase test coverage
  • Display loading status and error status in detail page
  • Talk with designer

Library used

  • Styling: Styled-component
  • State Management : Redux and redux-toolkits
  • Data fetching: axios, redux-saga
  • Routing: React router
  • Test: jest, testing-library

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant