[PR-verification] source-float: report streams candidate - #84301
Closed
Baz (bazarnov) wants to merge 7 commits into
Closed
[PR-verification] source-float: report streams candidate#84301Baz (bazarnov) wants to merge 7 commits into
Baz (bazarnov) wants to merge 7 commits into
Conversation
…eams Resolve conflicts in source-float metadata.yaml and float.md against upstream dependency bumps (0.0.47 -> 0.0.56): - keep dockerImageTag 0.1.0 for the new reports streams - keep the 0.1.0 changelog entry above the upstream dependency rows
…rce-float-add-reports-streams
…jects Addresses the AI PR review Test Coverage gate on #79087: source-float had no unit_tests project at all. Covers the behavior the two new report streams introduce: - root-key extraction (`people` / `projects`) via DpathExtractor, including sibling keys in the payload and null-valued fields - `start_date` trimmed from the config date-time to `YYYY-MM-DD`, `end_date` taken from config and defaulting to today via `now_utc()` - NoPagination: exactly one request, no `page` / `per-page` params - bearer auth, primary keys, full-refresh-only, inline schema vs emitted record - `end_date` declared optional in the spec, and the 16 pre-existing streams still discoverable Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…nd harden the new tests - Both report streams now carry start_date/end_date on every record via AddFields, using the same expressions as the request parameters - the aggregates are meaningless downstream without the period they cover, and the values change between syncs as the schedule changes. - Docs: report streams return one aggregated snapshot row per person or project for the configured range; full refresh overwrite recommended; end_date must not precede start_date. - Tests: the no-pagination test now fails fast instead of hanging if a paginator is ever added; 19 redundant per-field tests collapsed into a strict full-record equality round-trip; conftest owns the manifest/source helpers; unit_tests/__init__.py removed so conftest imports resolve (package-style unit_tests break pytest's conftest import path); wk_day_hrs fixture matches the documented shape.
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksPR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful Resources
|
Contributor
|
Note Autopilot progressive rollouts are not enabled for the following modified connector(s):
This is a courtesy heads-up only — it does not block merge or fail any check. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| | `end_date` | `string` | End Date (YYYY-MM-DD). Used by the reports streams. Defaults to today if not set. | | | ||
|
|
||
| ## Streams | ||
| | Stream Name | Primary Key | Pagination | Supports Full Sync | Supports Incremental | |
Contributor
There was a problem hiding this comment.
[markdownlint-fix] reported by reviewdog 🐶
Suggested change
| | Stream Name | Primary Key | Pagination | Supports Full Sync | Supports Incremental | | |
| | Stream Name | Primary Key | Pagination | Supports Full Sync | Supports Incremental | |
Contributor
|
Contributor
|
Deploy preview for airbyte-docs ready!
Deployed with vercel-action |
Contributor
Author
|
Validation complete - candidate checks green. Disposable PR, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Validation run for a candidate state of source-float 0.1.0: two new report streams (reports-people, reports-projects) with per-record reporting-period stamps, plus the connector's first unit test suite.
Scope
Note: this connector has no integration-test credentials in the secret store, so live suites are vacuous by construction - the meaningful signal here is the mock suite, lint and validators.
Do not merge - disposable verification PR.