Skip to content

fix: add timeout to Zoho CRM OAuth token refresh request #84238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Bunlong Heng (bunlongheng) wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −1
Draft

fix: add timeout to Zoho CRM OAuth token refresh request #84238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion airbyte-integrations/connectors/source-zoho-crm/source_zoho_crm/auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@
from airbyte_cdk.sources.streams.http.requests_native_auth import Oauth2Authenticator


# Timeout (in seconds) for the token refresh request so a hung endpoint cannot stall the sync indefinitely.
TOKEN_REFRESH_TIMEOUT = 60


class ZohoOauth2Authenticator(Oauth2Authenticator):
def _prepare_refresh_token_params(self) -> Dict[str, str]:
return {
Expand All @@ -28,7 +32,12 @@ def refresh_access_token(self) -> Tuple[str, int]:
Returns a tuple of (access_token, token_lifespan_in_seconds)
"""
try:
response = requests.request(method="POST", url=self.get_token_refresh_endpoint(), params=self._prepare_refresh_token_params())
response = requests.request(
method="POST",
url=self.get_token_refresh_endpoint(),
params=self._prepare_refresh_token_params(),
timeout=TOKEN_REFRESH_TIMEOUT,
)
response.raise_for_status()
response_json = response.json()
return response_json[self.get_access_token_name()], response_json[self.get_expires_in_name()]
Expand Down
Loading