ci: fix empty branch display in pre-release publish message - #71082
Merged
Aaron ("AJ") Steers (aaronsteers) merged 5 commits intoJan 1, 2026
Merged
Conversation
Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
Original prompt from AJ Steers |
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
When the workflow is triggered via MCP tool, it runs on master but passes gitref in inputs. However, if inputs.gitref is empty for any reason, the previous fallback to github.ref_name would incorrectly show 'master' instead of the PR branch. This fix adds a 'resolve-gitref' step that: 1. Uses inputs.gitref if provided 2. Falls back to fetching the PR head ref via GitHub API when PR number is available 3. Only falls back to github.ref_name as last resort The effective-gitref is now used consistently for: - Checkout - Comment display - Downstream publish_connectors.yml call Co-Authored-By: AJ Steers <aj@airbyte.io>
Simplify the gitref resolution to use GitHub's PR ref syntax directly:
- When PR number is provided, use refs/pull/{pr}/head (no API call needed)
- This ensures the execution source cannot be overridden by callers
- Change comment display from 'Branch: ...' to 'PR: #...' with link
The PR number is now the single source of truth for prerelease publishing.
Co-Authored-By: AJ Steers <aj@airbyte.io>
Co-Authored-By: AJ Steers <aj@airbyte.io>
Co-Authored-By: AJ Steers <aj@airbyte.io>
Aaron ("AJ") Steers (aaronsteers)
deleted the
devin/1767292618-fix-branch-display-prerelease
branch
January 1, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the empty "Branch:" field in pre-release connector publish messages. When
/publish-connectors-prereleaseis invoked (via slash command or MCP tool), the status comment showsBranch: ``instead of the actual branch name.Example of the bug (from airbytehq/airbyte#71063):
How
Simplified the workflow to always derive the git ref from the PR number:
pra required input (was optional)refs/pull/${{ inputs.pr }}/headinline for checkout and downstreampublish_connectors.ymlcallBranch: ...toPR: #...with a clickable linkgitrefinput description that it's ignored (kept for slash command dispatch compatibility)Key design decisions:
gitrefinput is kept but ignored (required by slash command dispatch static args)refs/pull/{pr}/headis the canonical way to reference PR codeReview guide
.github/workflows/publish-connectors-prerelease-command.yml- All changes in this fileHuman review checklist:
refs/pull/{pr}/headworks correctly for checkout and downstreampublish_connectors.ymlrefs/pull/{pr}/headis in the base repo)User Impact
Pre-release publish status comments will now correctly display a clickable PR link instead of showing an empty branch value.
Can this PR be safely reverted and rolled back?
Link to Devin run: https://app.devin.ai/sessions/8a26b7fcb0234672aced61d260dd706d
Requested by: AJ Steers (Aaron ("AJ") Steers (@aaronsteers))