ci: Fix slash command result detection to properly report success/failure - #71062
Merged
Aaron ("AJ") Steers (aaronsteers) merged 1 commit intoDec 30, 2025
Conversation
…lure The workflow output was using jobs.connector-ci-checks-summary.result (the job's completion status) instead of the step's output. This caused the slash command to always report success even when tests failed. Fixed by: 1. Adding outputs section to connector-ci-checks-summary job to expose the evaluate-status step output 2. Updating workflow output to reference jobs.connector-ci-checks-summary.outputs.result Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
Original prompt from AJ Steers |
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Helpful Resources
PR Slash CommandsAirbyte Maintainers (that's you!) can execute the following slash commands on your PR:
|
Aaron ("AJ") Steers (aaronsteers)
deleted the
devin/1767136944-fix-slash-command-result-detection
branch
December 30, 2025 23:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the
/run-connector-testsslash command always reporting "job completed successfully" even when tests fail. See this comment for an example where the command reported success despite test failures.How
The workflow output was using
jobs.connector-ci-checks-summary.resultwhich returns the job's completion status (success if the job runs without errors), not the step's output that evaluates whether the actual tests passed or failed.Fixed by:
outputssection to theconnector-ci-checks-summaryjob to expose theevaluate-statusstep outputjobs.connector-ci-checks-summary.outputs.resultinstead ofjobs.connector-ci-checks-summary.resultReview guide
.github/workflows/connector-ci-checks.yml- Two small changes:.resultto.outputs.resultoutputssection to expose the step outputUser Impact
Slash commands like
/run-connector-testswill now correctly report failure when tests fail, instead of always showing success.Can this PR be safely reverted and rolled back?
Link to Devin run: https://app.devin.ai/sessions/38464f16eb5f495cb72a77841632c875
Requested by: AJ Steers (Aaron ("AJ") Steers (@aaronsteers))