Skip to content

Destination MotherDuck: Finer grained custom user agent - #70813

Closed
Donny Peeters (Donnype) wants to merge 5 commits into
airbytehq:masterfrom
Donnype:donnypy/chore-finer-grained-custom-user-agent-motherduck-dest
Closed

Destination MotherDuck: Finer grained custom user agent#70813
Donny Peeters (Donnype) wants to merge 5 commits into
airbytehq:masterfrom
Donnype:donnypy/chore-finer-grained-custom-user-agent-motherduck-dest

Conversation

@Donnype

Copy link
Copy Markdown
Contributor

IMPORTANT: I set the version to 0.1.28 because I expect #70438 will be merged first, so hence this PR is a draft.

What

This PR makes the custom_user_agent include the AIRBYTE_VERSION and AIRBYTE_EDITION per the MotherDuck user agent specification. Note that AIRBYTE_EDITION is a bit of a shot in the dark as there are no docs on this environment variable, but locally I found it to be set to COMMUNITY, so I expect the Airbyte cloud to specify something else here.

How

This reads out the env when instantiating the MotherDuckConfig.

Review guide

User Impact

This should have no impact on users, but helps MotherDuck help users pinpoint issues with their integration.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

…tion: turning "airbyte" into "airbyte-CLOUD/2.0" or "airbyte-OSS" (depending on the actual values of the environment variables)
… to distinguish community and cloud deployment, and use the user-agent format specified by MotherDuck.
@github-actions

github-actions Bot commented Dec 9, 2025

Copy link
Copy Markdown
Contributor

👋 Welcome to Airbyte!

Thank you for your contribution from Donnype/airbyte! We're excited to have you in the Airbyte community.

Helpful Resources

PR Slash Commands

As needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
  • /run-connector-tests - Runs connector tests.
  • /run-cat-tests - Runs CAT tests.
  • /run-live-tests - Runs live tests for the modified connector(s).
  • /run-regression-tests - Runs regression tests for the modified connector(s).
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • /publish-connectors-prerelease - Publishes pre-release connector builds (tagged as {version}-dev.{git-sha}) for all modified connectors in the PR.

If you have any questions, feel free to ask in the PR comments or join our Slack community.

Tips for Working with CI

  1. Pre-Release Checks. Please pay attention to these, as they contain standard checks on the metadata.yaml file, docs requirements, etc. If you need help resolving a pre-release check, please ask a maintainer.
    • Note: If you are creating a new connector, please be sure to replace the default logo.svg file with a suitable icon.
  2. Connector CI Tests. Some failures here may be expected if your tests require credentials. Please review these results to ensure (1) unit tests are passing, if applicable, and (2) integration tests pass to the degree possible and expected.
  3. (Optional.) BYO Connector Credentials for tests in your fork. You can optionally set up your fork with BYO credentials for your connector. This can significantly speed up your review, ensuring your changes are fully tested before the maintainers begin their review.

📝 Edit this welcome message.

@DanyloGL

Danylo Jablonski (DanyloGL) commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator

/run-connector-tests

Connector CI Tests Started

These tests will leverage Airbyte's integration test credentials.

Check job output.
✅ Connector CI Tests job completed successfully. See logs for details.

@DanyloGL Danylo Jablonski (DanyloGL) moved this from New PRs to Waiting Eng Team in 🧑‍🏭 Community Pull Requests Jan 19, 2026
@jimruppert

Copy link
Copy Markdown
Contributor

Donny Peeters (@Donnype) The connector has moved on since this was opened (0.2.1 here vs 0.2.5 on master) and the branch now conflicts. Happy to look again at a rebased version.

We are closing a number of PRs that may be stale or redundant as a first step towards improved handling of PRs. If you believe this is currently still an issue, please comment and we'll reopen.

@Donnype

Copy link
Copy Markdown
Contributor Author

Jim Ruppert (@jimruppert) Done: #84292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Inactive

Development

Successfully merging this pull request may close these issues.

4 participants