Destination MotherDuck: Finer grained custom user agent - #70813
Destination MotherDuck: Finer grained custom user agent#70813Donny Peeters (Donnype) wants to merge 5 commits into
Conversation
…tion: turning "airbyte" into "airbyte-CLOUD/2.0" or "airbyte-OSS" (depending on the actual values of the environment variables)
… to distinguish community and cloud deployment, and use the user-agent format specified by MotherDuck.
👋 Welcome to Airbyte!Thank you for your contribution from Donnype/airbyte! We're excited to have you in the Airbyte community. Helpful Resources
PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
If you have any questions, feel free to ask in the PR comments or join our Slack community. Tips for Working with CI
|
…ent-motherduck-dest
|
/run-connector-tests
|
|
Donny Peeters (@Donnype) The connector has moved on since this was opened (0.2.1 here vs 0.2.5 on master) and the branch now conflicts. Happy to look again at a rebased version. We are closing a number of PRs that may be stale or redundant as a first step towards improved handling of PRs. If you believe this is currently still an issue, please comment and we'll reopen. |
IMPORTANT: I set the version to
0.1.28because I expect #70438 will be merged first, so hence this PR is a draft.What
This PR makes the
custom_user_agentinclude theAIRBYTE_VERSIONandAIRBYTE_EDITIONper the MotherDuck user agent specification. Note thatAIRBYTE_EDITIONis a bit of a shot in the dark as there are no docs on this environment variable, but locally I found it to be set toCOMMUNITY, so I expect the Airbyte cloud to specify something else here.How
This reads out the env when instantiating the
MotherDuckConfig.Review guide
User Impact
This should have no impact on users, but helps MotherDuck help users pinpoint issues with their integration.
Can this PR be safely reverted and rolled back?