chore(source-google-search-console): Migrate to CDK v6#59140
chore(source-google-search-console): Migrate to CDK v6#59140Christo Grabowski (ChristoGrab) merged 10 commits intomasterfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| with open(config_path, "w") as updated_config: | ||
| config = json.dumps(config) | ||
| updated_config.write(config) | ||
| def backup_config(): |
There was a problem hiding this comment.
The revert_migration test function was reformatting the local test_config.json file on each run, leading to formatting issues with our current pre-commit hooks. Not a big deal, but could be annoying for local dev work. Switching to a backup/restore of the original file fixed the issue for me.
| requests-mock = "^1.11.0" | ||
| pytest-lazy-fixture = "^0.6.3" | ||
| pytest = "^8.0.0" | ||
| pytest = "^7.4.0" |
There was a problem hiding this comment.
Reverted because pytest 8.0 does not play nice with the pytest-lazy-fixture dependency which is used in unit tests. Guessing there's a decent chance that unit tests will have to be adjusted anyway as we're migrating streams, so maybe we can rip out this dependency soon, but feels out of scope for this PR.
|
Kicked off a regression test here. Might take a while to finish, this source has some beefy read times: https://github.com/airbytehq/airbyte/actions/runs/14742276635/job/41382826417 |
Maxime Carbonneau-Leclerc (maxi297)
left a comment
There was a problem hiding this comment.
I saw from the regression tests that some of the streams have switched to being resumable. What are those streams? Should we disable this to keep the same behavior?
...ns/connectors/source-google-search-console/source_google_search_console/config_migrations.py
Outdated
Show resolved
Hide resolved
...connectors/source-google-search-console/unit_tests/test_migrations/test_config_migrations.py
Outdated
Show resolved
Hide resolved
|
/format-fix
|
Maxime Carbonneau-Leclerc (@maxi297) Was having a hard time interpreting the test report to figure out which streams were affected, but checking locally I noticed that Test run url: https://github.com/airbytehq/airbyte/actions/runs/14762282210 |
|
There seems to be some mismatches when syncing using a state. Are we able to explain these? |
|
Maxime Carbonneau-Leclerc (@maxi297) I don't think the record diffs in Link here: https://github.com/airbytehq/airbyte/actions/runs/14781221599/job/41500384114 NOTE: tested locally and didn't see anything suspicious from |
|
There is definitely something up with the |
|
Maxime Carbonneau-Leclerc (@maxi297) I looked into it and I think this may actually be a case of incremental behavior that was not previously working for I say this with the confidence of someone who is wrong about these things 95% of the time, but I think it may be worth moving forward with a progressive rollout. |
Maxime Carbonneau-Leclerc (maxi297)
left a comment
There was a problem hiding this comment.
If you think it's good to move forward with this, I'll approve!
|
/approve-regression-tests Record mismatch in search_analytics_keyword_site_report_by_site seems to be related to incremental reads correctly skipping records with
|
What
Migrates google-search-console to the latest major CDK version, in order to facilitate the migration of streams from the legacy CDK to low-code.
User Impact
Hopefully none, if any should be positive in the form of more mature CDK logic.
Can this PR be safely reverted and rolled back?