Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
1ee9be9
upgrade cdk version
Apr 22, 2025
2599e47
update release information
Apr 22, 2025
a9c0e6c
fix release information
Apr 22, 2025
5c16ec4
adding pendulum as it was removed from transitive dep
Apr 22, 2025
57cdf31
[TMP] move accounts to lowcode
Apr 23, 2025
5241bc0
fix schema, pagination and tenant
Apr 24, 2025
7f9ec6f
remove fixme
Apr 24, 2025
b687270
mlc: initial changes to make unit tests pass
aldogonzalez8 Apr 28, 2025
cf70e38
mlc: make most of unit test pass with source helpers
aldogonzalez8 Apr 28, 2025
ea05817
mlc: ruff format
aldogonzalez8 Apr 28, 2025
d52ea4c
mlc: add unit test for accounts stream
aldogonzalez8 Apr 29, 2025
e173919
mlc: ruff format
aldogonzalez8 Apr 29, 2025
cba9304
poetry lock
aldogonzalez8 Apr 29, 2025
a43c384
remove unnecesary imports and patches
aldogonzalez8 Apr 29, 2025
f6de83e
cleanup and documment
aldogonzalez8 Apr 29, 2025
9d31c83
change count of logs with checking specific empty data logs in output…
aldogonzalez8 Apr 29, 2025
da29b5b
ruff format
aldogonzalez8 Apr 29, 2025
a8a43ce
add cdk:low-code to tags
aldogonzalez8 Apr 29, 2025
3239dbc
remove comment of accounts stream
aldogonzalez8 Apr 29, 2025
701c209
move to inline schema
aldogonzalez8 Apr 30, 2025
8d5f109
ruff format
aldogonzalez8 Apr 30, 2025
0657d09
Merge branch 'master' into ac8/migrate-accounts-to-low-code
aldogonzalez8 Apr 30, 2025
d91ddb0
comment out disabled secret
aldogonzalez8 Apr 30, 2025
ad2d0f8
comment out disabled secret
aldogonzalez8 Apr 30, 2025
e5eb1e5
add transformation to keep previous schema
aldogonzalez8 Apr 30, 2025
7cf746b
prettier yaml
aldogonzalez8 Apr 30, 2025
43149b1
bump cdk version
aldogonzalez8 May 1, 2025
10c153b
Merge branch 'master' into ac8/migrate-accounts-to-low-code
aldogonzalez8 May 1, 2025
bf029a8
add transformations for id and date
aldogonzalez8 May 1, 2025
16243e3
move accounts schema to schemas section
aldogonzalez8 May 2, 2025
4339879
add test for linked agencies
aldogonzalez8 May 6, 2025
8bb767b
ruff format
aldogonzalez8 May 6, 2025
1faccba
update release information
aldogonzalez8 May 6, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions airbyte-integrations/connectors/source-bing-ads/metadata.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ data:
connectorSubtype: api
connectorType: source
definitionId: 47f25999-dd5e-4636-8c39-e7cea2453331
dockerImageTag: 2.8.13
dockerImageTag: 2.9.0-rc.1
dockerRepository: airbyte/source-bing-ads
documentationUrl: https://docs.airbyte.com/integrations/sources/bing-ads
erdUrl: https://dbdocs.io/airbyteio/source-bing-ads?view=relationships
Expand All @@ -36,6 +36,8 @@ data:
enabled: true
releaseStage: generally_available
releases:
rolloutConfiguration:
enableProgressiveRollout: true
breakingChanges:
1.0.0:
message: Version 1.0.0 removes the primary keys from the geographic performance report streams. This will prevent the connector from losing data in the incremental append+dedup sync mode because of deduplication and incorrect primary keys. A data reset and schema refresh of all the affected streams is required for the changes to take effect.
Expand All @@ -61,7 +63,7 @@ data:
supportLevel: certified
tags:
- language:python
- cdk:python
- cdk:low-code
connectorTestSuitesOptions:
- suite: liveTests
testConnections:
Expand All @@ -81,11 +83,6 @@ data:
secretStore:
type: GSM
alias: airbyte-connector-testing-secret-store
- name: SECRET_SOURCE-BING-ADS_NO_DATE_CREDS
fileName: config_no_date.json
secretStore:
type: GSM
alias: airbyte-connector-testing-secret-store
- name: SECRET_SOURCE-BING-ADS_NO_START_DATE__CREDS
fileName: config_no_date.json
secretStore:
Expand Down
1,154 changes: 797 additions & 357 deletions airbyte-integrations/connectors/source-bing-ads/poetry.lock

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ requires = [ "poetry-core>=1.0.0",]
build-backend = "poetry.core.masonry.api"

[tool.poetry]
version = "2.8.13"
version = "2.9.0-rc.1"
name = "source-bing-ads"
description = "Source implementation for Bing Ads."
authors = [ "Airbyte <contact@airbyte.io>",]
Expand All @@ -19,8 +19,9 @@ include = "source_bing_ads"
python = "^3.10,<3.12"
bingads = "==13.0.18.1"
urllib3 = "==1.26.18"
airbyte-cdk = "^5"
airbyte-cdk = "^6"
cached-property = "==1.5.2"
pendulum = "<3.0.0"

[tool.poetry.scripts]
source-bing-ads = "source_bing_ads.run:run"
Expand All @@ -29,7 +30,7 @@ source-bing-ads = "source_bing_ads.run:run"
freezegun = "^1.4.0"
pytest-mock = "^3.6.1"
pytest = "^8.0.0"
requests-mock = "^1.9.3"
requests-mock = "^1.12.1"


[tool.poe]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,20 @@
from numpy import nan

from airbyte_cdk.models import SyncMode
from airbyte_cdk.sources.streams import IncrementalMixin
from airbyte_cdk.sources.streams import CheckpointMixin
from airbyte_cdk.sources.utils.transform import TransformConfig, TypeTransformer
from source_bing_ads.base_streams import Accounts, BingAdsBaseStream
from source_bing_ads.utils import transform_bulk_datetime_format_to_rfc_3339


class BingAdsBulkStream(BingAdsBaseStream, IncrementalMixin, ABC):
class BingAdsBulkStream(BingAdsBaseStream, CheckpointMixin, ABC):
transformer: TypeTransformer = TypeTransformer(TransformConfig.DefaultSchemaNormalization | TransformConfig.CustomSchemaNormalization)
cursor_field = "Modified Time"
primary_key = "Id"
_state = {}

def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
self._state = {}

@staticmethod
@transformer.registerCustomTransform
Expand Down
Loading
Loading