Skip to content

chore: set up .tool-versions to use in github actions workflows#59129

Closed
devin-ai-integration[bot] wants to merge 5 commits intomasterfrom
devin/1745863242-asdf-setup
Closed

chore: set up .tool-versions to use in github actions workflows#59129
devin-ai-integration[bot] wants to merge 5 commits intomasterfrom
devin/1745863242-asdf-setup

Conversation

@devin-ai-integration
Copy link
Contributor

Set up asdf with .tool-versions

This PR adds a .tool-versions file containing the tool versions currently used in GitHub Actions workflows and updates the workflows to use the marocchino/tool-versions-action. This allows managing tool versions in a single place.

Changes:

  • Add .tool-versions file with Python, Java, and Poetry versions
  • Add tool-versions-action to workflows
  • Replace hardcoded versions with references to tool-versions step outputs

Requested by: Aaron ("AJ") Steers (aj@airbyte.io)

Link to Devin run: https://app.devin.ai/sessions/faac6654afb44c50b895d7e768f7c9aa

…n workflows

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner April 28, 2025 18:03
@vercel
Copy link

vercel bot commented Apr 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 28, 2025 7:39pm

@devin-ai-integration
Copy link
Contributor Author

Original prompt from Aaron:

@Devin - I want you to set up the CDK and the Airbyte repos to use asdf, including a .tool-versions file in each repo. Start by scanning the version numbers hardcoded into our existing github actions workflows. Then create a .tool-versions file containing all of the tools and versions that are currently hardcoded. Lastly, update those github workflows to leverage `marocchino/tool-versions-action` with a step id of `'tool-versions'. Everywhere in github actions you'd have a hardcoded version number, instead use the output of the new `tool-versions` step to feed the version number.

@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link

coderabbitai bot commented Apr 28, 2025

Caution

Review failed

An error occurred during the review process. Please try again later.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Co-Authored-By: Aaron <AJ> Steers <aj@airbyte.io>
@aaronsteers Aaron ("AJ") Steers (aaronsteers) changed the title chore: set up asdf with .tool-versions chore: set up .tool-versions to use in github actions workflows Apr 28, 2025
Copy link
Contributor

@dbgold17 David Gold (dbgold17) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with one comment

uses: actions/setup-python@v4
with:
python-version: "3.9.13" # install the python version needed
python-version: ${{ steps.tool-versions.outputs.python }} # install the python version needed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming this works with the version bump to 3.11 that you have defined, this all LGTM!

@devin-ai-integration
Copy link
Contributor Author

Closing due to inactivity for more than 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants