Source LinkedIn Ads - Update CDK #51041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
octavia-squidington-iii
added
area/connectors
ChristoGrab
reviewed
Jan 10, 2025
airbyte-integrations/connectors/source-linkedin-ads/pyproject.toml
Outdated
Show resolved
Hide resolved
lazebnyi
reviewed
Jan 13, 2025
| @@ -1,11 +1,13 @@ | |||
| # This file is automatically @generated by Poetry 1.6.1 and should not be changed by hand. | |||
| # This file is automatically @generated by Poetry 2.0.0 and should not be changed by hand. | |||
|
|
|||
| [[package]] | |||
| name = "airbyte-cdk" | |||
| version = "6.12.1.dev0" | |||
There was a problem hiding this comment.
It looks like it's still using the dev version of airbyte-cdk
There was a problem hiding this comment.
I did run poetry lock after the cdk version change, I will take another look at this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This (5.1.0-rc.2) was created to upgrade the CDK because it was discovered that:
5.1.0-rc.1 PR: #48863
Was using a dev version of the CDK here.
This should have changed the CDK to a production version but for some reason the lock file was not updated. Due to this another PR was made here: #51524
However there were some failing acceptance test. To prevent blocking users from fixes already implemented, the RC rollouts were cancelled and a copy of the version created in 5.1.0-rc.1 PR was manually merged in:
Manual 5.1.0 promotion PR: #51550
How
Review guide
User Impact
Can this PR be safely reverted and rolled back?