Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upgrading linkedin ads api version for creatives stream #49458

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

feat: Upgrading linkedin ads api version for creatives stream #49458

wants to merge 15 commits into from
+11 −5

Conversation

FVidalCarneiro
Copy link
Contributor

@FVidalCarneiro FVidalCarneiro commented Dec 13, 2024 •
edited
Loading

What

This PR aims to solve the issue (#49457). It does this quite simply by upgrading the linkedin ads version of the creatives stream to the 202410 version. This is an important step of the Linkedin ads API with its long term objective to deprecate the endpoints InMailContents API or the AdDirectSponsoredContents API.

How

Upgrading the manifest.yaml file of the source connector.

Review guide

  1. manifest.yaml

User Impact

User impacts only the creatives stream is only the addition of the name column. This can be confirmed here.

Can this PR be safely reverted and rolled back?

  • YES 💚 - however, the name field will no longer appear and will be removed from stream.
  • NO ❌

@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024

@FVidalCarneiro is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@octavia-squidington-iii octavia-squidington-iii added the area/connectors Connector related issues label Dec 13, 2024
@marcosmarxm marcosmarxm requested a review from lazebnyi December 13, 2024 13:15
marcosmarxm
marcosmarxm requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FVidalCarneiro thanks for update the connector. Update the connector version in the metadata.yaml and pyproject.toml files, also add an entry in the connector documentation for this change.

Would be possible to provide access to maintainers edit your branch? This is necessary to run tests, future format fixes and merging the contribution.

@octavia-squidington-iii octavia-squidington-iii added the area/documentation Improvements or additions to documentation label Dec 13, 2024
@kev-datams
Copy link
Contributor

hello @maxi297, @natikgadzhi, just added the name new field in schema 🙏

@vercel Vercel
Copy link

vercel bot commented Jan 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2025 2:16pm

@lazebnyi lazebnyi mentioned this pull request Jan 13, 2025
Closed
lazebnyi
lazebnyi reviewed Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@lazebnyi lazebnyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can move forward with this PR after @agarctfi finishes with the progressive rollout of #48863

@kev-datams
Copy link
Contributor

@lazebnyi thanks, do you know when the 5.1.0 will be officially available to be able to merge this one ?

@FVidalCarneiro
Copy link
Contributor Author

I think we can move forward with this PR after @agarctfi finishes with the progressive rollout of #48863

Hi @lazebnyi , I have just solved merge conflicts. Ready to merge now. Thank you, this small change is important for us 🙏

@natikgadzhi
Copy link
Contributor

Time for another rebase?

@kev-datams
Merge remote-tracking branch 'origin/master' into fvidalcarneiro/sour…
7f3e55a 
…ce-linkedin-ads-creatives-upgrade-feat

# Conflicts:
#	docs/integrations/sources/linkedin-ads.md
@kev-datams
Increase version to 5.1.2
723a221
@kev-datams kev-datams temporarily deployed to community-ci-auto January 15, 2025 20:13 — with GitHub Actions Inactive
@kev-datams
Copy link
Contributor

kev-datams commented Jan 15, 2025 •
edited
Loading

Time for another rebase?

hello @natikgadzhi @lazebnyi, all done ✅
please could you merge it 🙏
thanks a lot !

FYI @FVidalCarneiro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmarxm marcosmarxm Awaiting requested review from marcosmarxm

@natikgadzhi natikgadzhi Awaiting requested review from natikgadzhi

@lazebnyi lazebnyi Awaiting requested review from lazebnyi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/linkedin-ads
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@FVidalCarneiro @maxi297 @kev-datams @natikgadzhi @marcosmarxm @lazebnyi @octavia-squidington-iii