Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bulk-extract-cdk] skip errors caused by unparseable DDLs #48612

Merged
merged 1 commit into from
Nov 22, 2024
+2 −0
Merged

[bulk-extract-cdk] skip errors caused by unparseable DDLs #48612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...toolkits/extract-cdc/src/main/kotlin/io/airbyte/cdk/read/cdc/DebeziumPropertiesBuilder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ class DebeziumPropertiesBuilder(private val props: Properties = Properties()) {
with("value.converter.replace.null.with.default", "false")
// Timeout for DebeziumEngine's close() method.
with("debezium.embedded.shutdown.pause.before.interrupt.ms", "10000")
// Unblock CDC syncs by skipping errors caused by unparseable DDLs
with("schema.history.internal.skip.unparseable.ddl", "true")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed the correct Debezium property, but by adding these lines of code here you're setting this property for ALL connectors. Not all connectors maintain a schema history file. That being said, this is just ignored for those connectors, and it seems like this property is named the same way for all those that do maintain a schema history.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good point, currently do we have a way for all the connectors to share a common set of debezium properties, while allows specific connectors to include extra properties that won't be shared?

}

fun withOffset(): DebeziumPropertiesBuilder = apply {
Expand Down
Loading