chore: skip closed streams in flush tick. Log when flushing due to time wind… #48605
+78
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
| @@ -29,6 +31,8 @@ abstract class ChannelMessageQueue<T> : MessageQueue<T> { | |||
| override suspend fun close() { | |||
| channel.close() | |||
| } | |||
| @OptIn(DelicateCoroutinesApi::class) | |||
| override fun isClosedForPublish(): Boolean = channel.isClosedForSend | |||
There was a problem hiding this comment.
Another option besides opting in is to add an explicit closed flag to the interface
There was a problem hiding this comment.
Good call. I went with the don't add more state approach, but a flag could be a thing. I think I'm gonna go with this for now to get some test cycles in.
johnny-schmidt
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Checks if queue (channel) is closed before sending tick tasks
Adds log for visibility on time window trigger
How
MessageQueue#isClosedForPublishfor checking underlying channel