ci: skip py3.12 in test matrix #300
Conversation
📝 WalkthroughWalkthroughThe pull request modifies the GitHub Actions workflow configuration for pytest testing. Specifically, the Python version matrix in Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Hey there! I noticed you've commented out Python 3.12 in the test matrix. Would you mind sharing a bit more context about the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/pytest_matrix.yml (1)
33-33: LGTM! Clear documentation of the Python 3.12 exclusion.The comment clearly explains why Python 3.12 is being excluded and provides a link to the relevant issue. This is great for maintainability! 🎯
Hey, would it make sense to add a TODO comment to track when we should re-enable Python 3.12 testing once the
requests-cacheblocker is resolved? Something like:- # "3.12", # `requests-cache` blocker: https://github.com/airbytehq/airbyte-python-cdk/issues/299 + # TODO: Re-enable Python 3.12 once requests-cache is compatible: https://github.com/airbytehq/airbyte-python-cdk/issues/299 + # "3.12",wdyt? 🤔
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/pytest_matrix.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Pytest (Fast)
🔇 Additional comments (1)
.github/workflows/pytest_matrix.yml (1)
33-33: Verify test coverage impact.Let's check if removing Python 3.12 from the test matrix might impact our test coverage or miss any version-specific issues.
✅ Verification successful
Temporary removal of Python 3.12 testing is acceptable 👍
The codebase is explicitly configured to support Python versions up to 3.13, and the removal of Python 3.12 from the test matrix is purely due to a requests-cache dependency issue. No Python 3.12-specific code paths or features were found, and test coverage through Python 3.10 and 3.11 adequately covers the functionality. Once the requests-cache issue is resolved, Python 3.12 testing can be re-enabled without concerns.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for Python version specific imports or code paths # Look for version checks or imports that might be specific to Python 3.12 echo "Searching for Python version specific code..." rg -g '!.git' -g '*.py' "sys.version_info|python_version|@python_version|Python 3.12" . # Look for potential compatibility imports that might need Python 3.12 testing echo "Checking for compatibility imports..." rg -g '!.git' -g '*.py' "from __future__ import|import typing|from typing import" .Length of output: 40792
Script:
#!/bin/bash # Check for any Python version requirements in setup files and requirements echo "Checking setup.py and requirements files..." find . -type f -name "setup.py" -o -name "requirements*.txt" -o -name "pyproject.toml" | xargs cat # Check for any classifiers or Python version specifications echo "Checking for Python version classifiers..." find . -type f -name "setup.cfg" -o -name "setup.py" -o -name "pyproject.toml" | xargs grep -i "python_requires\|Programming Language :: Python\|requires-python"Length of output: 9258
Removing Py3.12 due to a concurrency issue / incompatibility in
requests-cachelibrary.requests-cachebreaks Python 3.12 compatibility #299Raised by @tolik0 as blocker for:
cc @natikgadzhi, @bnchrch, @maxi297 for visibility
Summary by CodeRabbit