Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added regex to sub special characters #545

Merged
merged 5 commits into from
Dec 10, 2024
+9 −1
Merged

Fix: Added regex to sub special characters #545

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dbffc27
added regex to sub special characters
tinomerl Dec 2, 2024
e19b95e
added comment to explain behaviour
tinomerl Dec 2, 2024
bff1359
Add Suggestions
tinomerl Dec 2, 2024
fddfa1b
expand comment
aaronsteers Dec 2, 2024
ee76045
used lowercasenormalizer
tinomerl Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion airbyte/_writers/file_writers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
from airbyte import exceptions as exc
from airbyte import progress
from airbyte._batch_handles import BatchHandle
from airbyte._util.name_normalizers import LowerCaseNormalizer
from airbyte._writers.base import AirbyteWriterInterface
from airbyte.records import StreamRecord, StreamRecordHandler

Expand Down Expand Up @@ -61,7 +62,14 @@ def _get_new_cache_file_path(
batch_id = batch_id or str(ulid.ULID())
target_dir = Path(self._cache_dir)
target_dir.mkdir(parents=True, exist_ok=True)
return target_dir / f"{stream_name}_{batch_id}{self.default_cache_file_suffix}"
# If a stream contains a special Character, the temporary jsonl.gz
# file can't be created, because of OS restrictions. Therefore, we
# remove the special characters, using the `LowerCaseNormalizer`.
# Specifically: we remove any of these characters: `<>:"/\|?*`
# and we remove characters in the ASCII range from 0 to 31.
normalizer = LowerCaseNormalizer()
normalized_stream_name = normalizer.normalize(stream_name)
return target_dir / f"{normalized_stream_name}_{batch_id}{self.default_cache_file_suffix}"

def _open_new_file(
self,
Expand Down
Loading