Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement maskable version of Graph2NodePPO (sb3 framework) #468

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

nhuet
Copy link
Contributor

@nhuet nhuet commented Feb 10, 2025

  • an action is a node of the observation graph
  • we use action masking to predict only applicable actions

@nhuet nhuet force-pushed the gnn2node-mask branch 3 times, most recently from ece2eed to aea1166 Compare February 20, 2025 10:47
@nhuet nhuet marked this pull request as draft February 20, 2025 10:47
@nhuet nhuet force-pushed the gnn2node-mask branch 2 times, most recently from 82bfe09 to 78dc1a2 Compare February 20, 2025 16:21
- an action is a node of the observation graph
- we use action masking to predict only applicable actions
- we add an example with variable number of nodes (as it may be relevant
  for action masks shapes handling)
- we add some docstrings to new algos and previous ones (GraphPPO,
  Graph2NodePPO, MaskableGraphPPO) and theirs policies.
@nhuet nhuet marked this pull request as ready for review February 21, 2025 08:46
@g-poveda g-poveda self-requested a review February 21, 2025 09:13
Copy link
Collaborator

@g-poveda g-poveda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g-poveda g-poveda merged commit 857c3a7 into airbus:master Feb 21, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants