Solve Python 3.12 and Starlette deprecations#272
Open
der-flo wants to merge 2 commits intoairbrake:masterfrom
Open
Solve Python 3.12 and Starlette deprecations#272der-flo wants to merge 2 commits intoairbrake:masterfrom
der-flo wants to merge 2 commits intoairbrake:masterfrom
Conversation
https://docs.python.org/3/library/datetime.html#datetime.datetime.utcfromtimestamp fixed warning with officially suggested solution
der-flo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My changes:
datetime.utcfromtimestampis deprecated in Python 3.12 - I fixed the warning with the officially suggested solution.ExceptionMiddlewareto be imported differently since 0.45.0,see Remove
ExceptionMiddlewareimport proxy fromstarlette.exceptionsmodule Kludex/starlette#2826It would be nice, if you merge my or similar changes and release a new version of the package. Thanks!
BTW: The test suite seems a bit outdated, I could not get it completely green. My changes are tested nevertheless.