Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in zerolog integration #270

Merged
merged 5 commits into from
May 4, 2022
Merged

add in zerolog integration #270

merged 5 commits into from
May 4, 2022

Conversation

Penthious
Copy link
Contributor

What

Add in zerolog support for Gobrake

Why

Cuz zerolog is super rad yo

zerolog/zerolog.go Outdated Show resolved Hide resolved
Copy link
Member

@mmcdaris mmcdaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! You may want to wait for @chimanjain to also have a look since he's worked on a lot of the recent integrations.

Copy link
Contributor

@scottsbaldwin scottsbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. There are some changes I'd suggest you make first.

examples/zerolog/main.go Outdated Show resolved Hide resolved
examples/zerolog/main.go Outdated Show resolved Hide resolved
examples/zerolog/main.go Outdated Show resolved Hide resolved
zerolog/zerolog.go Outdated Show resolved Hide resolved
zerolog/zerolog.go Show resolved Hide resolved
zerolog/zerolog.go Outdated Show resolved Hide resolved
zerolog/zerolog.go Outdated Show resolved Hide resolved
Copy link
Member

@thompiler thompiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

go.mod Outdated Show resolved Hide resolved
zerolog/zerolog.go Outdated Show resolved Hide resolved
Copy link
Contributor

@scottsbaldwin scottsbaldwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just take a look at @chimanjain comments)

@Penthious Penthious requested a review from chimanjain May 4, 2022 16:23
zerolog/zerolog.go Outdated Show resolved Hide resolved
examples/zerolog/main.go Outdated Show resolved Hide resolved
@chimanjain
Copy link
Contributor

LGTM

@Penthious Penthious merged commit bf4655e into master May 4, 2022
@Penthious Penthious deleted the feature/zerolog branch May 4, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants