only use Rails.version if it is defined #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyrylo
suggested changes
Feb 2, 2017
lib/airbrake/rack/context_filter.rb
Outdated
| @@ -7,7 +7,7 @@ module Rack | |||
| class ContextFilter | |||
| def initialize | |||
| @framework_version = | |||
| if defined?(::Rails) | |||
| if defined?(::Rails) and ::Rails.respond_to?(:version) | |||
There was a problem hiding this comment.
Rubocop will probably reject and. We use && in this project.
|
For some reason Circle didn't run tests for this PR. Could you fix #660 (comment), it will restart the tests. |
kyrylo
approved these changes
Feb 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an interesting situation.
I am writing a Grape API application using only Rack, however, I am using ActionMailer to send some emails in Sidekiq. Something inside one of the Action* gems is defining the module
Rails, but it's not fully loaded, as I am not using Rails. So when Airbrake gets to the point where it wants to use the context filter, it fails becauseversionis not defined in theRailsmodule.This code just checks to see if version is a defined attribute or method of the module
Rails.