Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stablizes transforms of class property arrow functions #135

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

sfrieson
Copy link
Contributor

@sfrieson sfrieson commented Aug 5, 2021

Closes #134, an issue I ran into when trying to migrate multiple repos that resulted in broken code in certain files.

I am not entirely sure if this is the best way to make the fix, so any pointers there would be appreciated. The fix is working for a minimal test case (in the test suite) as well as on my code base leaving the syntax in place and removing 15 of 392 @ts-expect-errors.

I have seen cases where white space can get messed up as mentioned in the comment for shouldReplace.

Willing to work towards a different solution is there is a better one.

@edsrzf
Copy link
Collaborator

edsrzf commented Aug 6, 2021

Thanks, I think this looks like a promising fix. I will take a closer look over the weekend. I've also found another issue or two I introduced in #127 that I will aim to fix.

@pmusiala
Copy link

Is it possible to merge it anytime soon?

@Rudeg Rudeg merged commit 9278ff8 into airbnb:master Aug 30, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration result in broken code for class members
4 participants