Work around jscodeshift arrow function bug #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recast, a jscodeshift dependency, has an issue where re-printed arrow functions returning object literals do not include surrounding parentheses, which means that code gets transformed in an invalid way. We can work around this issue by re-creating the object literal node, similar to an existing arrow funciton workaround.
Rudeg
approved these changes
May 1, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recast, a jscodeshift dependency, has an issue (benjamn/recast#743) where re-printed arrow functions returning object literals do not include surrounding parentheses, which means that code gets transformed in an invalid way. (
() => {}instead of() => ({}).)We can work around this issue by re-creating the object literal node, similar to an existing arrow function workaround.
Fixes #113.