Remove reference to SwiftLint Void rule #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
reviewed
Sep 6, 2024
README.md
Outdated
| @@ -2267,7 +2267,7 @@ _You can enable the following settings in Xcode by running [this script](resourc | |||
|
|
|||
| ### Closures | |||
|
|
|||
| * <a id='favor-void-closure-return'></a>(<a href='#favor-void-closure-return'>link</a>) **Favor `Void` return types over `()` in closure declarations.** If you must specify a `Void` return type in a function declaration, use `Void` rather than `()` to improve readability. [](https://realm.github.io/SwiftLint/void_return) | |||
| * <a id='favor-void-closure-return'></a>(<a href='#favor-void-closure-return'>link</a>) **Favor `Void` return types over `()` in closure declarations.** If you must specify a `Void` return type in a function declaration, use `Void` rather than `()` to improve readability. | |||
There was a problem hiding this comment.
We should include a badge for the SwiftFormat void rule
calda
reviewed
Sep 6, 2024
| @@ -89,7 +89,7 @@ The package plugin returns a non-zero exit code if there is a lint failure that | |||
|
|
|||
| _You can enable the following settings in Xcode by running [this script](resources/xcode_settings.bash), e.g. as part of a "Run Script" build phase._ | |||
|
|
|||
| * <a id='column-width'></a>(<a href='#column-width'>link</a>) **Each line should have a maximum column width of 100 characters.** [](https://github.com/nicklockwood/SwiftFormat/blob/master/Rules.md#wrap) | |||
| * <a id='column-width'></a>(<a href='#column-width'>link</a>) **Each line should have a maximum column width of 100 characters.** [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#wrap) | |||
calda
reviewed
Sep 6, 2024
| @@ -2267,7 +2267,7 @@ _You can enable the following settings in Xcode by running [this script](resourc | |||
|
|
|||
| ### Closures | |||
|
|
|||
| * <a id='favor-void-closure-return'></a>(<a href='#favor-void-closure-return'>link</a>) **Favor `Void` return types over `()` in closure declarations.** If you must specify a `Void` return type in a function declaration, use `Void` rather than `()` to improve readability. [](https://realm.github.io/SwiftLint/void_return) | |||
| * <a id='favor-void-closure-return'></a>(<a href='#favor-void-closure-return'>link</a>) **Favor `Void` return types over `()` in closure declarations.** If you must specify a `Void` return type in a function declaration, use `Void` rather than `()` to improve readability. [](https://github.com/nicklockwood/SwiftFormat/blob/main/Rules.md#void) | |||
calda
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reasoning