Add rule to omit internal
keyword from declarations with internal access control
#233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes a new rule to omit the
internal
keyword from declarations with internal access control.Autocorrect is implemented in the new
redundantInternal
SwiftFormat rule, which was added in nicklockwood/SwiftFormat#1486.Reasoning
Internal access control is implied for declarations without an explicit access control level, so the
internal
keyword is redundant.Please react with 👍/👎 if you agree or disagree with this proposal.