Add victorops as an output in streamalert. #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryxias
approved these changes
Feb 10, 2021
| "record": publication['record'] | ||
| } | ||
|
|
||
| LOGGER.critical('Sending alert to VictorOps') |
There was a problem hiding this comment.
Maybe change to LOGGER.info
|
|
||
| LOGGER.critical('Sending alert to VictorOps') | ||
| url = creds['url'] + '/' + creds['routing_key'] | ||
| resp = self._post_request( |
There was a problem hiding this comment.
Any value to use _post_request_retry instead?
|
Changed base onto |
ryandeivert
pushed a commit
that referenced
this pull request
Nov 4, 2021
* Add victorops as an output in streamalert. * linting fixes. * Update test_output_base to include victorops * Missing comma Co-authored-by: Zach Zeid <[email protected]> Co-authored-by: Ryxias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to:
cc: @airbnb/streamalert-maintainers
related to:
resolves:
Background
Increasing coverage of outputs to include VictorOps
We use VictorOps internally, and we wanted specific alerts so that Security Operations can be paged and begin triaging.
Changes
Added
victorops.pyas an output instreamalert/outputsTesting
Tested and deployed in local instance of Streamalert