Skip to content

Conversation

@stefhatcher
Copy link
Contributor

to: @milesj @stefhatcher @hayes @alecklandgraf

Description

Ran into a use case where it'd be handy to visually reverse the list, e.g. a list of facts ordered from most recent to oldest, needing to reverse that visually.

Also, fixed warning about adding horizontal onto li. Only apply that to <Item>s.

Testing

  • new stories
  • new tests

Screenshots

Screen Shot 2020-05-21 at 12 46 34 PM

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@airbnb-bot
Copy link
Collaborator

airbnb-bot commented May 21, 2020

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.2% 564.49 KB 563.55 KB 706.41 KB 705.43 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 577076,
    "lib": 722359
  },
  "forms": {
    "esm": 37217,
    "lib": 49149
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 578039,
    "lib": 723364
  },
  "forms": {
    "esm": 37217,
    "lib": 49149
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

@milesj
Copy link
Contributor

milesj commented May 21, 2020

@stefhatcher Some happo diffs seem off.

@stefhatcher
Copy link
Contributor Author

@milesj fixed!

@stefhatcher stefhatcher merged commit 4c2a87e into master May 21, 2020
@stefhatcher stefhatcher deleted the stefanie--reversed-list branch May 21, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants