Skip to content

Conversation

@moyus
Copy link
Collaborator

@moyus moyus commented May 6, 2020

Description

Remove redundant spacing after the last dot, so loader can be align horizontal center accurately.

Motivation and Context

As description.

Testing

Verified it looks correct in storyboard.

Screenshots

Screen Shot 2020-04-26 at 1 37 41 PM

Screen Shot 2020-04-26 at 1 38 11 PM

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@airbnb-bot
Copy link
Collaborator

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.0% 563.55 KB 563.47 KB 705.43 KB 705.35 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 576995,
    "lib": 722278
  },
  "forms": {
    "esm": 36180,
    "lib": 48408
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 577076,
    "lib": 722359
  },
  "forms": {
    "esm": 36180,
    "lib": 48408
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

@moyus
Copy link
Collaborator Author

moyus commented May 8, 2020

@milesj How can I fix the Happo check?

@milesj milesj merged commit 700b338 into master May 8, 2020
@milesj milesj deleted the fix-loader-spacing branch May 8, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants