Skip to content

Conversation

@williaster
Copy link
Contributor

@williaster williaster commented May 1, 2020

to: @milesj @stefhatcher @hayes @alecklandgraf

Description

This fixes a remaining comment from #367, and updates xLarge => xlarge for consistency in DataTables rowHeight options.

I tried removing the logic to create a new timeout if one existed, just letting the existing one run, but it broke the dynamic updating so I think we should keep it as is. EDIT: got this to work.

I also added a clearTimeout call on unmount.

Motivation and Context

See #367.

Testing

  • CI
  • functional – xlarge prop gives correct height

Screenshots

NA

Checklist

  • My code follows the style guide of this project.
  • I have updated or added documentation accordingly.
  • I have read the CONTRIBUTING document.

@airbnb-bot
Copy link
Collaborator

airbnb-bot commented May 1, 2020

Size Changes

Package Diff ESM Prev ESM CJS Prev CJS
core +0.0% 562.82 KB 562.7 KB 704.64 KB 704.52 KB

Compared to master. File sizes are unminified and ungzipped.

View raw build stats

Previous (master)

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 576205,
    "lib": 721427
  },
  "forms": {
    "esm": 36180,
    "lib": 48408
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

Current

{
  "apollo": {
    "esm": 10832,
    "lib": 14147
  },
  "app-shell": {
    "esm": 12906,
    "lib": 19874
  },
  "composer": {
    "esm": 68247,
    "lib": 101805
  },
  "core": {
    "esm": 576326,
    "lib": 721548
  },
  "forms": {
    "esm": 36180,
    "lib": 48408
  },
  "icons": {
    "esm": 156355,
    "lib": 205626
  },
  "layouts": {
    "esm": 15298,
    "lib": 20770
  },
  "metrics": {
    "esm": 5467,
    "lib": 7729
  },
  "test-utils": {
    "esm": 4279,
    "lib": 5937
  }
}

@williaster williaster force-pushed the chris--datatable-timeout-n-xlarge-ii branch from a7702f5 to aadb500 Compare May 1, 2020 21:20
@williaster williaster merged commit 078a64a into master May 1, 2020
@williaster williaster deleted the chris--datatable-timeout-n-xlarge-ii branch May 1, 2020 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants