-
Notifications
You must be signed in to change notification settings - Fork 86
Reduce the size of spark assembly artifact on par with sbt output #995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9f3c649 to
cf779d6
Compare
Please enter a commit message to explain why this merge is necessary,
4 tasks
piyush-zlai
reviewed
May 27, 2025
pengyu-hou
reviewed
May 28, 2025
This reverts commit 3f651a68d1b0f18d08378f740593df8236aa57f0.
Collaborator
|
@krisnaru could you also test it working with Spark 3.1.1? Thanks |
Contributor
Author
Yes, tested on spark 3.1.1 |
pengyu-hou
approved these changes
Jun 20, 2025
Collaborator
|
@hzding621 could you take a look at this PR? |
hzding621
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the bazel builds to produce the spark assembly artifacts on par with sbt artifacts w.r.t size.
Commands:
`
bazel build --config java_8 --config scala_2.11 --config spark_2.4 //spark:spark-assembly_deploy.jar
bazel build --config java_11 --config scala_2.12 --config spark_3.2 //spark:spark-assembly_deploy.jar
bazel build --config java_11 --config scala_2.12 --config spark_3.5 //spark:spark-assembly_deploy.jar
`
Updated minor version of spark 3.5 to 3.5.5
Why / Goal
To ensure the artifacts are tiny and dont collide with environment.
Checklist
Reviewers
@abbywh @tswitzer-netflix @pengyu-hou @hzding621