Bazel migration phase 2 #911
Conversation
krisnaru
force-pushed
the
bazel-phase-2
branch
13 times, most recently
from
b8ca5f9 to
9defeee
Compare
krisnaru
force-pushed
the
bazel-phase-2
branch
from
9defeee to
ae9e3a7
Compare
|
Will Bazel support all kinds of unit test frameworks like Junit, TestNG? |
lakshmanayenduri
left a comment
lakshmanayenduri
left a comment
There was a problem hiding this comment.
I suggest to add Verify statements in your test, not to just rely on asserts
| def testDecimal(): Unit = { | ||
|
|
||
| println("inside test") | ||
| val namespace = "test_decimal" |
There was a problem hiding this comment.
do we need println statement here?
There was a problem hiding this comment.
will remove it, good catch
jvm/spark_3_1_repo.bzl
Outdated
| "org.apache.datasketches:datasketches-java:2.0.0", | ||
| "org.apache.datasketches:datasketches-memory:1.3.0", | ||
| "org.apache.hive:hive-exec:3.1.2", | ||
| "org.apache.hive:hive-exec:2.3.7", |
There was a problem hiding this comment.
why are we downgrading the hive version?
There was a problem hiding this comment.
for spark 3.1, it requires to downgrade to compatible hive version
jvm/spark_3_5_repo.bzl
Outdated
| # Other dependencies | ||
| "org.apache.curator:apache-curator:2.12.0", | ||
| "com.esotericsoftware:kryo:5.1.1", | ||
| # "com.esotericsoftware:kryo:5.6.2", |
There was a problem hiding this comment.
remove the space between # and "
|
This PR has been open for sometime, can we please have an ETA for this? I am actually waiting to test this, seems Uber guys are waiting too. |
Thanks Laxman, I was on vacation. let me finish this by next week |
I will let @tswitzer-netflix to take over fixing unit tests with his PR: #991. thank you Tom. |
3 participants
Summary
Bazel migration phase 2
Why / Goal
Test Plan
Checklist
Reviewers