Update metadata export logic for join derivation #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzding621
reviewed
Nov 20, 2024
| tableUtils.createDatabase(namespace) | ||
| val viewsGroupBy = getViewsGroupBy(suffix = "cumulative", makeCumulative = true, namespace) | ||
| val joinConf = getEventsEventsTemporal("cumulative", namespace) | ||
| joinConf.setJoinParts(Seq(Builders.JoinPart(groupBy = viewsGroupBy)).asJava) |
There was a problem hiding this comment.
can you add a test case that contains external parts?
hzding621
reviewed
Nov 20, 2024
| StructType(derivedDummyOutputDf.schema.filterNot(f => keyAndPartitionFields.map(_.name).contains(f.name)))) | ||
| ListBuffer(columns.map { tup => toAggregationMetadata(tup._1, tup._2, joinConf.hasDerivations) }: _*) | ||
| } else { | ||
| aggregationsMetadata |
There was a problem hiding this comment.
nit: rename agg because agg is specific to group_by, but now we have external parts and derivations
aggMetadata=>joinOutputFieldsMetadataaggregationsMetadata=>joinIntermediateFieldsMetadata
hzding621
reviewed
Nov 20, 2024
| expression = "*" | ||
| ), Derivation( | ||
| name = "test_feature_name", | ||
| expression = f"${viewsGroupBy.metaData.name}_time_spent_ms_average" |
There was a problem hiding this comment.
Can you add some derivations that use ts and ds as inputs?
There was a problem hiding this comment.
Similarly, can we add a test case for key columns as output?
such as
Derivation(
name = "event_id",
expression = "ext_contextual_event_id"
)
hzding621
reviewed
Nov 20, 2024
| val finalOutputColumns = joinConf.derivationsScala.finalOutputColumn(dummyOutputDf.columns).toSeq | ||
| val derivedDummyOutputDf = dummyOutputDf.select(finalOutputColumns: _*) | ||
| val columns = SparkConversions.toChrononSchema( | ||
| StructType(derivedDummyOutputDf.schema.filterNot(f => keyAndPartitionFields.map(_.name).contains(f.name)))) |
There was a problem hiding this comment.
Is the filterNot necessary here? I think we should keep everything that users included in derivations. For example, we should allow key columns to be in the output if users explicitly included it in derivations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the metadata export logic for join with derivation. Use derived columns as exported features.
Why / Goal
Test Plan
Checklist
Reviewers
@hzding621 @pengyu-hou @SophieYu41