[WIP] Mill Migration 👀👀👀 #1052
Draft
[WIP] Mill Migration 👀👀👀 #1052
+1,236
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
If we actually do mill it needs to be baked into the image I think |
abbywh
force-pushed
the
awhittier/mill
branch
2 times, most recently
from
174ed3e to
83e4cc7
Compare
…ation Add Mill build configuration alongside existing sbt build: - Mill package.mill files for all modules (api, aggregator, online, spark, flink, service) - Thrift code generation for Java (api module) - Python Thrift generation and wheel building commands - CircleCI jobs for Mill compilation, tests, and Python API builds - prepareScalaSources command to handle scala-2.12 version-specific sources Mill commands: ./mill api.prepareScalaSources # Copy scala-2.12 sources (one-time setup) ./mill <module>.compile # Compile modules ./mill <module>.test # Run tests ./mill generatePythonThrift # Generate Python Thrift files ./mill buildPythonApi # Build Python wheel Test fixes: - Migrate test modules from ScalaTest to JUnit4 (tests use JUnit annotations) - Fix Mockito verification in FetcherCacheTest - Fix MetadataExporterTest to use filesystem path instead of JAR resource - Update Python build script to use venv Both Mill and sbt build systems work simultaneously.
abbywh
force-pushed
the
awhittier/mill
branch
from
83e4cc7 to
9233bf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Wanted to try out mill, it mostly worked off
./mill initWhy / Goal
Trying out mill just for fun.
Test Plan
Checklist
Reviewers