Skip to content

Conversation

@PolinaRodimova
Copy link

Summary

Adding attributes field to metadata for GroupBy and Join to pass company specific information

Why / Goal

Allow to passthrough some custom and company related information without adding dedicated fields

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

Copy link
Collaborator

@hzding621 hzding621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today, kwargs is passed in GroupBy and Join which is saved in custom_json in metadata. It's intended that companies/users leverage kwargs and custom_json for their custom metadata, so I think we may not need to introduce another attributes parameter here. In your internal code, you can create wrappers for GroupBy/Join Python APIs with more explicit parameters for your custom metadata.

@nikhil-zlai
Copy link
Collaborator

Today, kwargs is passed in GroupBy and Join which is saved in custom_json in metadata. It's intended that companies/users leverage kwargs and custom_json for their custom metadata

@PolinaRodimova - if you go down the customJson route, could you please make a doc change for posterity's sake?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants