Skip to content

Conversation

@abbywh
Copy link
Contributor

@abbywh abbywh commented Aug 10, 2025

Summary

Continuation of #991

  • Finished OSSing our Bazel Integration
  • Added it to circleCI
  • Added dev container support
  • OSSd our thrift fixes (shout out to @pyalex for that one)
  • Still only build for spark 3.2

Why / Goal

  • Unify the build system to make OSSing changes easier

Test Plan

  • [ x ] Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

@abbywh abbywh changed the title Bazel fixes, Bazel CI, Dev Containers [WIP] Bazel fixes, Bazel CI, Dev Containers Aug 10, 2025
@nikhil-zlai
Copy link
Collaborator

we have a PR in our fork that upgrades bazel to 8.x and uses the latest rules_scala 7.0.

zipline-ai/chronon#958

@abbywh
Copy link
Contributor Author

abbywh commented Aug 12, 2025

@nikhil-zlai Nice! I plan to cherry pick this once I have a few more of the updates cherry picked. Notably, we haven't ran the codemod yet. I figured I'd start at least getting it in circleci.

@abbywh
Copy link
Contributor Author

abbywh commented Aug 17, 2025

nice!!! Time to optimize a bit hopefully

@abbywh
Copy link
Contributor Author

abbywh commented Aug 18, 2025

ok, got a few minutes cut, most of the tricks didn't work. We need to set this up with a remote cache or it will always be strictly slower than sbt. Reached out about build buddy https://chrononworkspace.slack.com/archives/C04K2SLPZU7/p1755431220095059

@@ -0,0 +1 @@
../thrift/api.thrift No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this file?

Copy link
Collaborator

@pengyu-hou pengyu-hou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it another try? I was following this page on how to use env vars: https://circleci.com/docs/guides/security/env-vars/#example-configuration-of-environment-variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants