-
Notifications
You must be signed in to change notification settings - Fork 83
[WIP] Bazel fixes, Bazel CI, Dev Containers #1023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…_repos.bzl to resolve merge conflicts and improve clarity
|
we have a PR in our fork that upgrades bazel to 8.x and uses the latest rules_scala 7.0. |
|
@nikhil-zlai Nice! I plan to cherry pick this once I have a few more of the updates cherry picked. Notably, we haven't ran the codemod yet. I figured I'd start at least getting it in circleci. |
|
nice!!! Time to optimize a bit hopefully |
|
ok, got a few minutes cut, most of the tricks didn't work. We need to set this up with a remote cache or it will always be strictly slower than sbt. Reached out about build buddy https://chrononworkspace.slack.com/archives/C04K2SLPZU7/p1755431220095059 |
Co-authored-by: Ben Schellenberger <[email protected]> Signed-off-by: Abby Whittier <[email protected]>
…into bazel-nflx-fixes
| @@ -0,0 +1 @@ | |||
| ../thrift/api.thrift No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give it another try? I was following this page on how to use env vars: https://circleci.com/docs/guides/security/env-vars/#example-configuration-of-environment-variables
Signed-off-by: Pengyu Hou <[email protected]>
Signed-off-by: Pengyu Hou <[email protected]>
Summary
Continuation of #991
Why / Goal
Test Plan
Checklist
Reviewers