Fix unable to find showkase root issue #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were reports of this issue(#212) where screenshot tests weren't able to generate due to a build issue after the KSP upgrade. This was happening only if the
ShowkaseRootimplementation was not declared in anandroidTestsourceSet. Since the sample used in Showkase relied on a root implementation declared in theandroidTestsourceSet, I wasn't able to repro this issue locally. I spent some time trying to figure out why the class wasn't being found on the classpath and wondered if it had something to do with XProcessing. Eventually, it struck me that we had also updated the retention of the annotation.Thanks @davidvavra for sharing the project where I was able to observe what was causing the issue.
@airbnb/showkase-maintainers