Fix issue with submodule components not showing up #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2022
elihart
approved these changes
Jan 24, 2022
vinaygaba
force-pushed
the
vinay-fix-multi-module-issue
branch
from
6b8a402 to
348e781
Compare
|
Added a new submodule and corresponding test updates in order to make sure this doesn't happen again in the future @airbnb/showkase-maintainers |
|
@vinaygaba Can you please release this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple reports of submodule components not showing up in the Showkase Browser after the Ksp refactor(#194).
#213
#203
This PR simply fixes that. Looked like we needed to go one level lower in the Elements tree to look for the submodule components (same logic existed prior to the refactor too).
@airbnb/showkase-maintainers