Remove useKsp flag for kapt

It looks like it runs ksp anyway if the property is there
airbnb · Sep 28, 2022 · aa46317 · aa46317
1 parent 48ac6c6
commit aa46317
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 13 deletions.
diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
@@ -56,7 +56,7 @@ jobs:
           api-level: ${{ matrix.api-level }}
           target: ${{ matrix.target }}
           arch: x86_64
-          script: ./gradlew connectedCheck --no-daemon --stacktrace -PuseKsp=false
+          script: ./gradlew connectedCheck --no-daemon --stacktrace
 
       - name: Run UI Tests w/ KSP
         uses: reactivecircus/android-emulator-runner@v2

diff --git a/showkase-processor/src/main/java/com/airbnb/android/showkase/processor/ShowkaseProcessor.kt b/showkase-processor/src/main/java/com/airbnb/android/showkase/processor/ShowkaseProcessor.kt
@@ -126,11 +126,6 @@ class ShowkaseProcessor @JvmOverloads constructor(
 
         // This is for getting custom annotations from the supported types.
         val customAnnotationMetadata = processCustomAnnotation(roundEnvironment)
-        previewComposablesMetadata.forEach {
-
-            //writeDebugFile(it.showkaseName)
-        }
-
 
         return (
                 showkaseComposablesMetadata +
@@ -364,13 +359,12 @@ class ShowkaseProcessor @JvmOverloads constructor(
         if (rootElement != null) {
             // This is the module that should aggregate all the other metadata files and
             // also use the showkaseMetadata set from the current round to write the final file.
-            showkaseProcessorMetadata =
-                writeShowkaseFiles(
-                    rootElement,
-                    componentMetadata,
-                    colorMetadata,
-                    typographyMetadata
-                )
+            showkaseProcessorMetadata = writeShowkaseFiles(
+                rootElement,
+                componentMetadata,
+                colorMetadata,
+                typographyMetadata
+            )
 
         }