fix(opentelemetry): adjust default value for store_spans_in_file ca…

…using traces to be produced to a file named `None` (ansible-collections#8741) * fix(opentelemetry): adjust default value for `store_spans_in_file` causing traces to be produced to a file named `None` The commit 5f48193 introduced `store_spans_in_file` with the default value `None` as a string. This causes the value of `store_spans_in_file` to be a not empty string, value=None as a string and not a null value. The rest of the code check if the store_spans_in_file is not null which squeezes the rest of the code. The following commit set the default value as an empty string. Signed-off-by: Wilfried Roset <[email protected]> * fix(opentelemetry): No default value is better, reword changelog Signed-off-by: Wilfried Roset <[email protected]> --------- Signed-off-by: Wilfried Roset <[email protected]>
aioue · Oct 1, 2024 · caa23fb · caa23fb
1 parent 75897b9
commit caa23fb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/changelogs/fragments/8741-fix-opentelemetry-callback.yml b/changelogs/fragments/8741-fix-opentelemetry-callback.yml
@@ -0,0 +1,2 @@
+minor_changes:
+  - opentelemetry callback plugin - fix default value for ``store_spans_in_file`` causing traces to be produced to a file named ``None`` (https://github.com/ansible-collections/community.general/issues/8566, https://github.com/ansible-collections/community.general/pull/8741).
diff --git a/plugins/callback/opentelemetry.py b/plugins/callback/opentelemetry.py
@@ -85,7 +85,6 @@
             key: disable_attributes_in_logs
         version_added: 7.1.0
       store_spans_in_file:
-        default: None
         type: str
         description:
           -  It stores the exported spans in the given file
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		minor_changes:
		- opentelemetry callback plugin - fix default value for ``store_spans_in_file`` causing traces to be produced to a file named ``None`` (https://github.com/ansible-collections/community.general/issues/8566, https://github.com/ansible-collections/community.general/pull/8741).