Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added "experiment" type method to pdb_search #5

Merged
merged 4 commits into from
Aug 7, 2024
Merged

added "experiment" type method to pdb_search #5

merged 4 commits into from
Aug 7, 2024

Conversation

tomshani
Copy link
Contributor

@tomshani tomshani commented Jul 8, 2024

I added the necessary addition to the unit test...hope there's no issue

jbenjoseph
jbenjoseph requested changes Jul 9, 2024
View reviewed changes
Copy link
Member

@jbenjoseph jbenjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run this code though the black formatter?

pip install pre-commit && pre-commit install && pre-commit run --all-files

jbenjoseph
jbenjoseph requested changes Jul 21, 2024
View reviewed changes
Copy link
Member

@jbenjoseph jbenjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure self is the first parameter of all Object methods.

aiondata/raw/protein_structure.py Outdated Show resolved Hide resolved
@jbenjoseph jbenjoseph merged commit 7940f28 into aion-labs:main Aug 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbenjoseph jbenjoseph jbenjoseph requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomshani @jbenjoseph