-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aiohttp tests to CI #1415
Open
Cycloctane
wants to merge
8
commits into
aio-libs:master
Choose a base branch
from
Cycloctane:tests_aiohttp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−0
Open
Add aiohttp tests to CI #1415
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
30c9ba3
add aiohttp tests
Cycloctane 36b840a
update chaneg note
Cycloctane 307aee7
force color
Cycloctane c3bf75b
Fix workflow
asvetlov ac690fa
remove dev_mode tests
Cycloctane d2ed168
update change note
Cycloctane c1021ee
remove unnecessary pip upgrade step
Cycloctane bc78e56
remove unnecessary step
Cycloctane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| --- | ||
|
|
||
| name: Aiohttp | ||
|
|
||
|
|
||
| on: | ||
| merge_group: | ||
| push: | ||
| branches: | ||
| - master | ||
| tags: | ||
| - v* | ||
| pull_request: | ||
| branches: | ||
| - master | ||
|
|
||
|
|
||
| env: | ||
| COLOR: "yes" | ||
| FORCE_COLOR: 1 | ||
| PY_COLORS: 1 | ||
|
|
||
|
|
||
| jobs: | ||
|
|
||
| test-aiohttp: | ||
| name: Aiohttp tests | ||
| runs-on: ubuntu-latest | ||
| timeout-minutes: 30 | ||
| steps: | ||
| - name: Checkout aiohttp | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: aio-libs/aiohttp | ||
| submodules: true | ||
| - name: Checkout yarl | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| path: vendor/yarl | ||
| - name: Setup Python | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.x | ||
| cache: pip | ||
| cache-dependency-path: requirements/*.txt | ||
| - name: Provision the dev env | ||
| run: make .develop | ||
| - name: Cythonize yarl | ||
| working-directory: vendor/yarl | ||
| run: make cythonize | ||
| - name: Install yarl | ||
| working-directory: vendor/yarl | ||
| run: >- | ||
| python -m pip install -e . | ||
| - name: Run tests | ||
| run: python -m pytest | ||
| shell: bash | ||
|
|
||
| ... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Started running downstream :mod:`aiohttp` tests in CI -- by :user:`Cycloctane`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want to make this check required in pull requests, it must be integrated into the main CI/CD workflow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind too much, but running a different project's test suite kind of feels to me like it's cleaner to me to be in a separate file. We can still add this as a separate required status in the repo settings.