-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] 📦 Move packaging to PEP 517 in-tree backend #1009
base: master
Are you sure you want to change the base?
[DNM] 📦 Move packaging to PEP 517 in-tree backend #1009
Conversation
This essentially allows the cythonization opt-out be controlled by the `pure-python` PEP 517 config setting that can be passed to the corresponding build frontends via their respective CLIs.
from shutil import copytree | ||
from sys import implementation as _system_implementation | ||
from sys import stderr as _standard_error_stream | ||
from sys import version_info as _python_version_tuple |
Check notice
Code scanning / CodeQL
Unused import Note
# with suppress(ImportError): | ||
# # NOTE: Only available for wheel builds that bundle C-extensions. Declared | ||
# # NOTE: by `get_requires_for_build_wheel()` and | ||
# # NOTE: `get_requires_for_build_editable()`, when `pure-python` | ||
# # NOTE: is not passed. | ||
# from Cython.Build.Cythonize import main as _cythonize_cli_cmd |
Check notice
Code scanning / CodeQL
Commented-out code Note
# with _patched_cython_env(config['env'], line_tracing_requested): | ||
# _cythonize_cli_cmd(cythonize_args) |
Check notice
Code scanning / CodeQL
Commented-out code Note
from ._backend import ( # type: ignore[assignment] # noqa: WPS436 | ||
build_sdist, | ||
build_wheel, | ||
# get_requires_for_build_wheel, | ||
prepare_metadata_for_build_wheel, | ||
) |
Check notice
Code scanning / CodeQL
Unused import Note
Import of 'build_wheel' is not used.
Import of 'prepare_metadata_for_build_wheel' is not used.
from ._backend import ( # type: ignore[assignment] # noqa: WPS436 | ||
build_editable, | ||
# get_requires_for_build_editable, | ||
prepare_metadata_for_build_editable, | ||
) |
Check notice
Code scanning / CodeQL
Unused import Note
Import of 'prepare_metadata_for_build_editable' is not used.
This is me cleaning up uncommitted things lying around on disk. It needs some love. Do not merge. IIRC, the thing that I was trying to figure out last was generating gcov coverage, looking into https://gcovr.com. It supposedly needs to be compiled twice (unlike what was needed for Cython) with some non-optimized flags, but I haven't gotten it to work. If anybody has ideas — plz document them here. |
This essentially allows the cythonization opt-out be controlled by the
pure-python
PEP 517 config setting that can be passed to the corresponding build frontends via their respective CLIs.