#506 anyio integration #507
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jettify
reviewed
Mar 18, 2023
|
|
||
| def _notify_sync_not_full(self) -> None: | ||
| def f() -> None: | ||
| with self._sync_mutex: | ||
| self._sync_not_full.notify() | ||
|
|
||
| fut = asyncio.ensure_future(self._loop.run_in_executor(None, f)) | ||
| fut = asyncio.ensure_future(anyio.to_thread.run_sync(f, *[])) |
There was a problem hiding this comment.
I do not think there is any interest to support anyio between maintainers, this is asyncio library after all. I do not have experience with it, but may be anyio can provide custom executor so self._loop.run_in_executor can call anyio.to_thread.run_sync(f, *[]) ? Then there is not need to change library itself much, other then may be provide executor for the loop.
|
Looking at the source, PR still keeps strong dependency on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.