Don't run ROLLBACK when the connection is closed. #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be caused when a query times out while running, for example, and the connection is closed as a result (as opposed to cancelling the query, since PR aio-libs#570). In this case, we would rather not emit the ROLLBACK (the connection is already closed, so the transaction is over anyway), rather than raising an exception when trying to use a connection which is already closed. See issue aio-libs#777.
brianmaissy
force-pushed
the
dont-rollback-transaction-if-connection-is-closed
branch
from
d576656 to
5408cac
Compare
Pliner
reviewed
Dec 23, 2020
Codecov Report
@@ Coverage Diff @@
## master #778 +/- ##
==========================================
+ Coverage 93.10% 93.20% +0.10%
==========================================
Files 13 13
Lines 1537 1545 +8
Branches 172 176 +4
==========================================
+ Hits 1431 1440 +9
+ Misses 78 76 -2
- Partials 28 29 +1
Continue to review full report at Codecov.
|
|
@Pliner have you had a chance to go over this again? |
Sure, I have. I'm a bit unsure about the way how it's resolved in PR, let me try to propose alternative one in a couple of days. |
|
@Pliner bump? |
Pliner
approved these changes
Mar 22, 2021
|
@brianmaissy thanks for your contribution and sorry for the long delay. I've slightly modified PR and it is merged to master now. I'm going to create new dev version today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #777.
This can be caused when a query times out while running, for example, and the connection is closed as a result (as opposed to cancelling the query, since PR #570). In this case, we would rather not emit the ROLLBACK (the connection is already closed, so the transaction is over anyway), rather than raising an exception when trying to use a connection which is already closed.
I wasn't sure if it was cleaner to do this here (inside the implementation of rollback) or in the context manager of the transaction. The disadvantage of this implementation is that here we are also affecting any rollback that someone does manually, but implementing it in the context manager is awkward since it doesn't have access to the connection object, and we wouldn't have a way to set
self._transaction = Noneandself._is_begin = False.If you think the side effect of making all ROLLBACKs on a closed connection silently do nothing is fine, we can leave it like this. Otherwise maybe we can add another intermediate method
rollback_unless_closedor something like that which the context manager calls, which does the check and calls rollback if necessary.