Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python 3.8 warnings in tests #771

Merged
merged 4 commits into from
Dec 20, 2020
Merged

Fix python 3.8 warnings in tests #771

merged 4 commits into from
Dec 20, 2020

Conversation

Pliner
Copy link
Member

@Pliner Pliner commented Dec 20, 2020

What do these changes do?

Fix deprecation warnings where a loop argument is passed to asyncio APIs. Continues #642

Are there changes in behavior for the user?

Nope

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes

@Pliner Pliner force-pushed the fix-tests-warnings-py38 branch from 913721d to e4ae61d Compare December 20, 2020 15:31
@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #771 (97ace16) into master (9ba9b48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #771   +/-   ##
=======================================
  Coverage   93.08%   93.08%           
=======================================
  Files          13       13           
  Lines        1532     1532           
  Branches      172      172           
=======================================
  Hits         1426     1426           
  Misses         78       78           
  Partials       28       28           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ba9b48...97ace16. Read the comment docs.

@Pliner Pliner merged commit 52532fb into master Dec 20, 2020
@Pliner Pliner deleted the fix-tests-warnings-py38 branch December 20, 2020 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant