Make aiopg installable in PyPy environment

[avanov]

No description provided.

[asvetlov]

Please enable PyPy in travis config to make sure that library is really functional on PyPy.

[avanov]

Is there a list of pypy versions available on Travis CI, or do they follow the same naming scheme as pyenv does? I test the package against pypy3.5-5.8.0 locally.

[asvetlov]

https://docs.travis-ci.com/user/languages/python/#PyPy-Support

[codecov]

Codecov Report

Merging #361 into master will increase coverage by 0.06%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   93.49%   93.55%   +0.06%     
==========================================
  Files          23       26       +3     
  Lines        3550     3570      +20     
  Branches      205      209       +4     
==========================================
+ Hits         3319     3340      +21     
+ Misses        186      184       -2     
- Partials       45       46       +1

Impacted Files	Coverage Δ
tests/test_sa_engine.py	98.93% <100%> (+0.04%)	⬆️
tests/test_extended_types.py	100% <100%> (ø)	⬆️
aiopg/utils.py	81.61% <100%> (+0.41%)	⬆️
tests/test_cursor.py	100% <100%> (ø)	⬆️
aiopg/psycopg2_compat/__init__.py	100% <100%> (ø)
aiopg/pool.py	98.89% <100%> (ø)	⬆️
tests/test_connection.py	98.21% <100%> (-0.01%)	⬇️
tests/conftest.py	66.66% <100%> (+1.2%)	⬆️
aiopg/psycopg2_compat/extras.py	100% <100%> (ø)
tests/test_sa_connection.py	100% <100%> (ø)	⬆️
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3d37c...8535cbe. Read the comment docs.

[avanov]

Ok, currently builds fail on PyPy because of the presence of psycopg2 in requirements.txt. What is the reason for having psycopg2 pinned in requirements.txt?

[jettify]

I have never used psycopg2cffi, but what happened if compat.register() called two times? or after first import of psycopg2 in other module?

[avanov]

@jettify it imports psycopg2cffi and makes it available under psycopg2 name in sys.modules (see https://github.com/chtd/psycopg2cffi/blob/master/psycopg2cffi/compat.py)

As long asaiopg.utils is imported in the main package namespace before psycopg2, all subsequent occurences of psycopg2 will be mapped to already imported psycopg2cffi (including relative import cases that go through the main aiopg namespace anyway).

[asvetlov]

Hmm.
Thanks @jettify for pointing on.
Maybe better to explicitly import either psycopg2 or psycopg2cffi?
Doing this we'll never catch an import order problem.

[avanov]

@asvetlov do you mean you would prefer psycopg2_compat module with sth like this inside?

# aiopg/psycopg2_compat

if PY_IMPL == 'PyPy':
    from psycopg2cffi import *
else:
    from psycopg2 import *

[asvetlov]

Yes, please do

[avanov]

@asvetlov shall I remove psycopg2 from requirements.txt ?

[jettify]

We use requirements.txt to track updated with pyup bot, so can be removed, I believe.

[avanov]

The test failures for CPython environments are now consistent with #362 due to changes introduced to psycopg2 between version 2.6.2 and 2.7.3. TravisCI now fetches the most recent psycopg2 version during the python setup.py install build step.

[Daenyth]

This would be a great feature to have!

[steven-upside]

I see that this commit has been approved, are there plans to merge this anytime soon? PyPy + aiopg would be a great combination!

[asvetlov]

1. PR was approved by arbitrary github user, not aiopg committer. Basically it is an another form to say "I like it, +1"
2. Tests are still fails, the Pull Request is not ready for merging yet.

[avanov]

@steven-upside so yes, I am waiting for a response from psycopg2cffi on the issue above, and on another one at chtd/psycopg2cffi#85 , after which I think I could finalise this PR.

[avanov]

closing this as no longer relevant