-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation warnings in asyncio with Python 3.8 #622
Comments
@dmajda hi! what version of aiopg are you using? in version 1.0.0explicit transfer has been replaced with get_running_loop |
We use 1.0.0. Here are some specific places where the warnings pop up: These were caught by a test suite of one of @energomonitor’s internal projects that uses aiopg (we have warnings enabled when running tests). There may be some more places which our test suite didn’t catch. |
Thank. Yes. I think it will be necessary to do this. |
Done. Review, please |
Resolved by #642 |
When using aiopg with Python 3.8 with warnings enabled, deprecation warnings are emitted at various places where a
loop
argument is passed toasyncio
APIs. To quote from What’s New In Python 3.8:It would be good to fix these warnings. I’m not sure whether it would involve just refactoring few
asyncio
API calls, or whether it would require deeper changes in loop handling inside the library.The text was updated successfully, but these errors were encountered: