Add optional pool connections recycling #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New version available https://pypi.python.org/pypi/aioodbc/0.3.0 |
|
Awesome, thanks @jettify for the fast merge and version release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This basically copies what was done in aio-libs/aiopg/pull/373, the biggest difference being the test.
It's not clear to me how the test in
aiopgwas testing that the connection is actually being recycled. The test in this PR fails without the recycling logic, and passes with it. If I'm mistaken and the logic from theaiopgtest is necessary please tell me and I'll add it here too.Should I add a small note indicating this feature in the documentation somewhere?
Thanks